Refactor: ChainType and LedgerType #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: OjusWiZard <[email protected]>
Signed-off-by: OjusWiZard <[email protected]>
Signed-off-by: OjusWiZard <[email protected]>
OjusWiZard
force-pushed
the
refactor/chain
branch
from
8c495bb
to
b8b67bf
Compare
truemiller
approved these changes
Nov 14, 2024
jmoreira-valory
approved these changes
Nov 15, 2024
OjusWiZard
merged commit 4d89409
into
feat/allow-multiple-services-middleware
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
ChainTypeas integers toChainas chain namesas integers toLedgerType` as ledger namesTypes of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply