Compute env vars #444
Compute env vars #444
Conversation
| "USE_MECH_MARKETPLACE": "mech_marketplace" | ||
| in service.chain_configs[ | ||
| service.home_chain_id | ||
| ].chain_data.user_params.staking_program_id, |
There was a problem hiding this comment.
@0xArdi Is this approach correct? I mean, if the service is staked in multiple chains, and we could have different combinations of mech marketplace or not, what value should this environment variable have? Currently it is set to true if the home chain staking contract is a mech_marketplace one.
There was a problem hiding this comment.
I think the mech_interact_abci only allows for the agent to work with the mech in a single chain.
This param here might tell us what chain the mech is meant to be used on. Perhaps that needs to be checked instead of assuming its always the home_chain_id.
frontend/client/types.ts
Outdated
| @@ -1,7 +1,7 @@ | |||
| import { StakingProgramId } from '@/enums/StakingProgram'; | |||
| import { Address } from '@/types/Address'; | |||
|
|
|||
| import { DeploymentStatus, Ledger, MiddlewareChain, EnvProvisionType } from './enums'; | |||
There was a problem hiding this comment.
If we don't use EnvProvisionType from enums.ts then can we remove it from there? I'm guessing it's not used anywhere else
There was a problem hiding this comment.
Fixed, was using the wrong enum in the file.
|
|
||
| # TODO A customized, arbitrary computation mechanism should be devised. | ||
| computed_values = { | ||
| "ETHEREUM_LEDGER_RPC": PUBLIC_RPCS[ChainType.ETHEREUM], |
There was a problem hiding this comment.
ideally we can remove these hardcode rpcs from middleware at some point
and instead use valory endpoints from .env, the current PUBLIC_RPCS are public/rate-limited
may be inconsistent with tenderly forks, if they're not overwritten
may be sync issues with rpcs frontend calls & middleware calls
There was a problem hiding this comment.
Agree, there is a refactor task to do in the RPCs. Surprisingly "PUBLIC_RPCs" here are overriden by the environment variables GNOSIS_DEV_RPC, etc.
This is task of another PR, though.
jmoreira-valory
merged commit c4a6253
into
feat/allow-multiple-services-middleware
Proposed changes
Compute env vars
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply