Fix public OTA updates #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanya-atatakai
approved these changes
Jun 5, 2024
|
This worked for me, but two things I notice:
I suggest we keep this on a separate branch and merge with Mohan's work. Then assess from there. We need to have user safety as top of mind. |
mohandast52
approved these changes
Jun 6, 2024
| const publishOptions = { | ||
| const githubOptions = { | ||
| releaseType: 'draft', | ||
| publishAutoUpdate: true, |
There was a problem hiding this comment.
@oaksprout commented that the user has to manually update it.
truemiller
merged commit 17fa130
into
mohan/improve-update-experience
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can test from rc34.2 -> rc34.3
@mohandast52 please see github publish config, as it's different from the previously discussed.
have removed
channelsattribute as this array applied to SnapStore channels, not GithubOptions