fix start agent balance thresholds

[truemiller]

• start agent button was disabled in some states where it shouldn't be

[Tanya-atatakai]

do we need this commented code line? if yes, don't understand how it's checked above

[truemiller]

the condition is covered on L179:

olas-operate-app/frontend/components/Main/MainHeader.tsx

Line 179 in d8d926b

if (serviceStatus === DeploymentStatus.DEPLOYED) {

had left the comment for context around why it's not included in the statuses where agent should not be deployable

can remove though, let me know 🙏

[mohandast52]

It looks good, but it might be personal preference, I haven't commonly seen IIFE being used. Also, regarding condition, can be added just to avoid confusion, but it is up to you.

function checkDeployability() {
  // case where required values are undefined (not fetched from the server)
  if (totalEthBalance === undefined || totalOlasBalance === undefined || !services) {
    return false;
  }

  // deployment statuses where agent should not be deployed
  if (
    serviceStatus === DeploymentStatus.DEPLOYED || 
    serviceStatus === DeploymentStatus.DEPLOYING ||
    serviceStatus === DeploymentStatus.STOPPING
  ) {
    return false;
  }

  // case where service exists & user has initial funded
  if (services[0] && storeState?.isInitialFunded) {
    return totalOlasBalance >= requiredOlas; // at present agent will always require staked/bonded OLAS
  }

  return totalOlasBalance >= requiredOlas && totalEthBalance > requiredGas;
}

const isDeployable = checkDeployability();

if (!isDeployable) {
  return (
    <Button type="default" size="large" disabled>
      Start agent
    </Button>
  );
}

[mohandast52]

It looks good, but it might be personal preference, I haven't commonly seen IIFE being used. Also, regarding condition, can be added just to avoid confusion, but it is up to you.

function checkDeployability() {
  // case where required values are undefined (not fetched from the server)
  if (totalEthBalance === undefined || totalOlasBalance === undefined || !services) {
    return false;
  }

  // deployment statuses where agent should not be deployed
  if (
    serviceStatus === DeploymentStatus.DEPLOYED || 
    serviceStatus === DeploymentStatus.DEPLOYING ||
    serviceStatus === DeploymentStatus.STOPPING
  ) {
    return false;
  }

  // case where service exists & user has initial funded
  if (services[0] && storeState?.isInitialFunded) {
    return totalOlasBalance >= requiredOlas; // at present agent will always require staked/bonded OLAS
  }

  return totalOlasBalance >= requiredOlas && totalEthBalance > requiredGas;
}

const isDeployable = checkDeployability();

if (!isDeployable) {
  return (
    <Button type="default" size="large" disabled>
      Start agent
    </Button>
  );
}