Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lost the 'installing dependencies' message on all loads. #148

Merged
merged 2 commits into from
May 29, 2024
Merged

fix: lost the 'installing dependencies' message on all loads. #148

merged 2 commits into from
May 29, 2024

Conversation

mohandast52
Copy link
Collaborator

@mohandast52 mohandast52 commented May 28, 2024 •
edited
Loading

  • Implemented a falsy check to verify if the message is displayed. Could someone please double-check this? 🙏
Screenshot2

@mohandast52 mohandast52 self-assigned this May 28, 2024
@mohandast52 mohandast52 marked this pull request as ready for review May 28, 2024 08:09
@Tanya-atatakai
Copy link
Collaborator

@mohandast52 works for me 🙏
image

@mohandast52 mohandast52 merged commit 6217b24 into main May 29, 2024
2 of 4 checks passed
@mohandast52 mohandast52 deleted the mohan/fix-install-dependency-message branch May 29, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tanya-atatakai Tanya-atatakai Tanya-atatakai approved these changes

@oaksprout oaksprout oaksprout approved these changes

@truemiller truemiller truemiller approved these changes

Assignees

@mohandast52 mohandast52

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohandast52 @Tanya-atatakai @truemiller @oaksprout