Open sourcing requirements #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
truemiller
commented
May 24, 2024
•
truemiller
commented
- Updates to README
- Improved release workflow; stops releases from other branches/pull requests (security risk)
- Added Gitleaks workflow + initial .gitleaksignore
- Removed private repo settings, and read-only update key
truemiller
changed the title
truemiller
requested review from
Tanya-atatakai and
mohandast52
and removed request for
Tanya-atatakai
truemiller
changed the title
Tanya-atatakai
approved these changes
May 27, 2024
There was a problem hiding this comment.
lgtm! a small question:
I noticed that poetry.lock was generated with "Poetry 1.8.2" but in the readme we say that we use "Poetry (1.7.1)" - @truemiller do you know which is correct?
Also noticed that this job is failing, do you what's the reason and if this can be fixed?
Will update poetry version, and reach out to Viraj on this as it's a backend linter I believe |
mohandast52
approved these changes
May 27, 2024
…erate-app into josh/open-source-reqs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.