Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify difference between account creation & master safe #120

Merged
merged 2 commits into from
May 23, 2024

Conversation

Tanya-atatakai
Copy link
Collaborator

Only updated Setup page so we don't have conflicts with Mohan (I assume he's working on main page - can get back to it later)
Screenshot 2024-05-22 at 21 59 30

<Button
onClick={handleBack}
disabled={disabled}
icon={<ArrowLeftOutlined />}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed this so that the button is square as in Figma

background-image: url("data:image/svg+xml,%3csvg width='100%25' height='100%25' xmlns='http://www.w3.org/2000/svg'%3e%3crect width='100%25' height='100%25' fill='none' rx='12' ry='12' stroke='%23A3AEBB' stroke-width='2' stroke-dasharray='6' stroke-dashoffset='15' stroke-linecap='square'/%3e%3c/svg%3e");
border-radius: 12px;

.account-creation-alert {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that we have different alerts in Figma and here (mostly in terms of colors and icons which look better in Figma imo) - we use info alert that sometimes should be violet and sometimes blue. I suggest we use "Success" for violet - in antd tokens? and\or create our own Alert component where we use custom icons and colors. WDYT @mohandast52 @truemiller ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i think we should create custom ones, and ask for them to be uniform if they are different in different places

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, works for me.

@@ -66,6 +66,7 @@ button, input, select, textarea, .ant-input-suffix {
border-left: 0;
border-right: 0;
margin: -24px;
align-items: flex-start;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing icon is on top as in Figma

@@ -42,6 +42,8 @@ export const mainTheme: ThemeConfig = {
colorTextLightSolid: 'black',
colorBgSpotlight: 'white',
},
Typography: {},
Typography: {
colorTextDescription: '#4D596A',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it sets color for Typgraphy.Text type=secondary - I think it suits better rather than just default gray. lmkyt ...

@Tanya-atatakai Tanya-atatakai requested review from truemiller and mohandast52 and removed request for truemiller May 22, 2024 18:20
frontend/components/Setup/Create/SetupEoaFunding.tsx Outdated Show resolved Hide resolved
background-image: url("data:image/svg+xml,%3csvg width='100%25' height='100%25' xmlns='http://www.w3.org/2000/svg'%3e%3crect width='100%25' height='100%25' fill='none' rx='12' ry='12' stroke='%23A3AEBB' stroke-width='2' stroke-dasharray='6' stroke-dashoffset='15' stroke-linecap='square'/%3e%3c/svg%3e");
border-radius: 12px;

.account-creation-alert {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, works for me.

@Tanya-atatakai Tanya-atatakai force-pushed the tanya/account-creation-and-safe-diff branch from d4f8063 to b2718d7 Compare May 23, 2024 07:50
@Tanya-atatakai Tanya-atatakai merged commit d9fd7eb into main May 23, 2024
2 of 3 checks passed
@Tanya-atatakai Tanya-atatakai deleted the tanya/account-creation-and-safe-diff branch May 23, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants