-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify difference between account creation & master safe #120
Conversation
<Button | ||
onClick={handleBack} | ||
disabled={disabled} | ||
icon={<ArrowLeftOutlined />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this so that the button is square as in Figma
background-image: url("data:image/svg+xml,%3csvg width='100%25' height='100%25' xmlns='http://www.w3.org/2000/svg'%3e%3crect width='100%25' height='100%25' fill='none' rx='12' ry='12' stroke='%23A3AEBB' stroke-width='2' stroke-dasharray='6' stroke-dashoffset='15' stroke-linecap='square'/%3e%3c/svg%3e"); | ||
border-radius: 12px; | ||
|
||
.account-creation-alert { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that we have different alerts in Figma and here (mostly in terms of colors and icons which look better in Figma imo) - we use info alert that sometimes should be violet and sometimes blue. I suggest we use "Success" for violet - in antd tokens? and\or create our own Alert component where we use custom icons and colors. WDYT @mohandast52 @truemiller ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i think we should create custom ones, and ask for them to be uniform if they are different in different places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, works for me.
@@ -66,6 +66,7 @@ button, input, select, textarea, .ant-input-suffix { | |||
border-left: 0; | |||
border-right: 0; | |||
margin: -24px; | |||
align-items: flex-start; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing icon is on top as in Figma
@@ -42,6 +42,8 @@ export const mainTheme: ThemeConfig = { | |||
colorTextLightSolid: 'black', | |||
colorBgSpotlight: 'white', | |||
}, | |||
Typography: {}, | |||
Typography: { | |||
colorTextDescription: '#4D596A', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it sets color for Typgraphy.Text type=secondary
- I think it suits better rather than just default gray. lmkyt ...
background-image: url("data:image/svg+xml,%3csvg width='100%25' height='100%25' xmlns='http://www.w3.org/2000/svg'%3e%3crect width='100%25' height='100%25' fill='none' rx='12' ry='12' stroke='%23A3AEBB' stroke-width='2' stroke-dasharray='6' stroke-dashoffset='15' stroke-linecap='square'/%3e%3c/svg%3e"); | ||
border-radius: 12px; | ||
|
||
.account-creation-alert { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, works for me.
d4f8063
to
b2718d7
Compare
Only updated Setup page so we don't have conflicts with Mohan (I assume he's working on main page - can get back to it later)