Update readme #37
Merged
Update readme #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagacha
reviewed
Aug 1, 2023
|
|
||
| ```bash | ||
| aea generate-key ethereum | ||
| export ETHEREUM_LEDGER_RPC=INSERT_YOUR_RPC | ||
| export ETHEREUM_LEDGER_CHAIN_ID=100 |
There was a problem hiding this comment.
Not for now, but we need to change the variable name ETHEREUM_LEDGER_RPC to RPC or similar, but it implies changes in the code.
There was a problem hiding this comment.
I discussed this with @0xArdi . In this case ETHEREUM refers to ETHEREUM-type ledger (instead of cosmos), not ETHEREUM chain. But I agree this needs to be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update readme