Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test task "Project A" #20

Open
wants to merge 17 commits into
base: fix/demo
Choose a base branch
from
Open

Conversation

actionless
Copy link

@actionless actionless commented Aug 6, 2024

i've implemented Behavior and Handler themselves but i didn't figured out how exactly i should edit the config files to run 2 of them and communicate - so i was not able to test it neither manually or write an integration test.

The design is light on details intentionally – we encourage you to make
clarifications and request changes

i guess you could clarify my aforementioned problem as part of the review of this PR 😺

@actionless
Copy link
Author

@dvilelaf @angrybayblade @dagacha

i can't assign you as a reviewer due to permissions in the repo, but you should get a notification from a mention anyway

@actionless
Copy link
Author

Marija suggested to also add @Adamantios to the thread

Copy link
Collaborator

@dvilelaf dvilelaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yauhen! Sorry for the late response. I think there has been some misunderstanding with the exercise. We do not expect you to use Open-Autonomy or any of our repos to implement it.

Feel free to just use pure Python to implement a very simple "agent" that satisfies the requirements. Take it as an academic exercise, no need for complexity, just a couple of classes and methods to implement something that exchanges messages.

@actionless
Copy link
Author

actionless commented Aug 12, 2024

hi @dvilelaf , i've been traveling so saw your message only now.

yup, i can re-implement it without use of the framework, but in that case i wonder which protocol should i use for communication between the agents? (particularly i'm concerned that in case of using pure python and http protocol - re-implementing aiohttp would take some effort)

@dvilelaf
Copy link
Collaborator

dvilelaf commented Aug 13, 2024 via email

@actionless
Copy link
Author

so, you mean that i could use agents as just python functions running inside the same eventloop?

@dvilelaf
Copy link
Collaborator

dvilelaf commented Aug 13, 2024 via email

@actionless
Copy link
Author

aight, then i'll implement it as mentioned above (as functions executed inside the same python process), but i'll leave interface easily extendable for implementing further features, like changing communication protocol

i'll make it as a PR to new empty repo on my account

talk to you tomorrow!

@actionless
Copy link
Author

i've created the PR there: actionless/valory-project-a-rev2#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants