Setting multisig guards via Guard factory #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
Apr 13, 2023
kupermind
commented
- Proof of concept to set a multisig guar via the Guard factory;
- Preliminary test works, need to add more tests.
kupermind
commented
Apr 14, 2023
| constructor (address _owner) { | ||
| /// @dev Initializes the Safe Guard instance by setting its owner. | ||
| /// @param _owner Safe Guard owner address. | ||
| function initialize (address _owner) external { |
There was a problem hiding this comment.
Safe Guard contract is initializable via the Safe Guard factory now.
kupermind
commented
Apr 14, 2023
|
|
||
| // Execute the payload, if provided | ||
| // The payload must be executed before the safe guard is set, as the payload could potentially break the guard | ||
| if (payloadLength > 0) { |
There was a problem hiding this comment.
The custom payload is called also via a delegatecall(), as it would be called from the module manager of the GnosisSafe contract initialization.
kupermind
commented
Apr 14, 2023
Comment on lines
+127
to
+129
| assembly { | ||
| guard := create2(0, add(bytecode, 0x20), mload(bytecode), salt) | ||
| } |
There was a problem hiding this comment.
Safe Guard instance is created, and the last multisig owner is set as the created Safe Guard owner.
kupermind
commented
Apr 14, 2023
| // SPDX-License-Identifier: MIT | ||
| pragma solidity ^0.8.19; | ||
|
|
||
| contract DelegateCall { |
There was a problem hiding this comment.
Test DelegateCall contract
77ph
pushed a commit
that referenced
this pull request
Oct 12, 2023
refactor: reward function for protocol-owned services
77ph
pushed a commit
that referenced
this pull request
Oct 12, 2023
chore and test: creating fuzzer auxiliary contract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.