chore: added title to Veolas for duplicate title error in SEMrush #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atepem
requested review from
mohandast52,
oaksprout,
Tanya-atatakai and
truemiller
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
mohandast52
reviewed
Nov 14, 2024
| import { IncreaseLockModal } from "./IncreaseLockModal"; | ||
| import { VeOlasManage } from "./VeOlasManage"; | ||
| import { GetServerSideProps } from "next"; | ||
| import Head from "next/head"; |
There was a problem hiding this comment.
your linter is not working 🥲
Tanya-atatakai
requested changes
Nov 14, 2024
| Lock OLAS for veOLAS | ||
| </Button> | ||
| <> | ||
| <Head> |
There was a problem hiding this comment.
could you please add the whole meta block to govern app similar to one that we have on olas website or contribute or in bond app here apps/bond/pages/_app.jsx? currently govern app is not searchable in google :( I probably forgot to add that when created the app
Tanya-atatakai
requested changes
Nov 14, 2024
| </Button> | ||
| <> | ||
| <Head> | ||
| <title>VeOlas</title> |
There was a problem hiding this comment.
or maybe Govern | veOLAS
apps/govern/pages/veolas.tsx
Outdated
| const VeOlasPage = () => ( | ||
| <> | ||
| <Meta | ||
| pageTitle="veOlas" |
There was a problem hiding this comment.
Suggested change
| pageTitle="veOlas" | |
| pageTitle="veOLAS" |
Tanya-atatakai
approved these changes
Nov 14, 2024
oaksprout
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Just added a title to VeOlas to resolve SEMrush issues, duplicate title tags:
