Feat/threads #92
Merged
Feat/threads #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvilelaf
commented
Sep 11, 2023
Comment on lines
+183
to
+195
| if isinstance(text, list): | ||
| # Thread | ||
| previous_tweet_id = None | ||
| for tweet in text: | ||
| if not previous_tweet_id: | ||
| response = api.create_tweet(text=tweet) | ||
| else: | ||
| response = api.create_tweet(text=tweet, in_reply_to_tweet_id=previous_tweet_id) | ||
| previous_tweet_id = response.data["id"] | ||
| else: | ||
| # Single tweet | ||
| response = api.create_tweet(text=text) | ||
|
|
There was a problem hiding this comment.
Thread implementation: if the data passed is a list, we post it as a thread.
dvilelaf
commented
Sep 11, 2023
| @@ -80,7 +80,7 @@ extra: | |||
| termination_sleep: ${TERMINATION_SLEEP:int:900} | |||
| reset_pause_duration: ${RESET_PAUSE_DURATION:int:300} | |||
| on_chain_service_id: ${ON_CHAIN_SERVICE_ID:int:null} | |||
| reset_tendermint_after: ${RESET_TENDERMINT_AFTER:int:300} | |||
| reset_tendermint_after: ${RESET_TENDERMINT_AFTER:int:30} | |||
dvilelaf
commented
Sep 11, 2023
Comment on lines
+610
to
+618
| Event.NO_MAJORITY: TwitterRandomnessRound, | ||
| Event.ROUND_TIMEOUT: TwitterRandomnessRound, | ||
| }, | ||
| TwitterHashtagsCollectionRound: { | ||
| Event.DONE: TwitterDecisionMakingRound, | ||
| Event.DONE_MAX_RETRIES: TwitterDecisionMakingRound, | ||
| Event.API_ERROR: TwitterHashtagsCollectionRound, | ||
| Event.NO_MAJORITY: TwitterHashtagsCollectionRound, | ||
| Event.ROUND_TIMEOUT: TwitterHashtagsCollectionRound, | ||
| Event.NO_MAJORITY: TwitterRandomnessRound, | ||
| Event.ROUND_TIMEOUT: TwitterRandomnessRound, |
There was a problem hiding this comment.
We should select new keepers whenever we time out. I found an issue today where the service was stuck in a timeout loop.
0xArdi
approved these changes
Sep 11, 2023
angrybayblade
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes
n/a
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.Further comments
n/a