Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError on closing of django runserver #157

Closed
wants to merge 1 commit into from

Conversation

slimadvies
Copy link

When closing Django runserver, valkey client consistently throws the AttributeError in the function del

This patch fixes that problem

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

When closing Django runserver, valkey client consistently throws the AttributeError in the function __del__

This patch fixes that problem

Signed-off-by: Samuel Lim <[email protected]>
@mkmkme
Copy link
Collaborator

mkmkme commented Dec 18, 2024

Hey! Thanks for your contribution.
The code unfortunately doesn't look like a fix but rather like a workaround for an existing problem.
Could you please create an issue with the detailed description of the problem? What exactly do you do to get this exception thrown, what version you're using and what is the stack trace?

Thank you in advance!

@slimadvies
Copy link
Author

Issue #158

@mkmkme
Copy link
Collaborator

mkmkme commented Dec 18, 2024

Thank you! I'll have to close this PR in order to fix the root cause of the issue.

@mkmkme mkmkme closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants