Fix LOADU8 #156
Merged
Fix LOADU8 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was generating wrong results
lialan
force-pushed
the
takumi/fix_loadu8
branch
from
a2b57a8
to
5fc8ad0
Compare
thealmarty
reviewed
Apr 22, 2024
| state | ||
| .mem_mut() | ||
| .write(clk, write_addr_index, cell_to_write, true); | ||
| .write(clk, write_addr_index, Word::from_u8(cell_byte), true); |
There was a problem hiding this comment.
Hm....I was assuming little endian format and that's why the byte is written to [0] with zero_extend_byte but maybe it should be at the end like from_u8?
The C test doesn't work either way probably because there are more bugs. But write is working so perhaps I should indeed use from_u8. If so we should remove zero_extend_byte.
There was a problem hiding this comment.
And also then I should change sign_extend_byte. I pushed a commit. Test still not working.
thealmarty
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was generating wrong results