Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage in ci #109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sbellem
Copy link

@sbellem sbellem commented Feb 4, 2024

Thought this may be useful. See example at https://app.codecov.io/github/sbellem/valida/tree/coverage/valida.

@morganthomas
Copy link
Collaborator

I think that generating code coverage reports would be useful. Thanks, @sbellem ! It doesn't look like uploading code coverage to codecov.io is working in CI currently:

[2024-02-04T16:38:18.130Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Could not find a repository, try using repo upload token', code='not_found')}

It would be nice to update the README with instructions on how to access the generated code coverage reports, and perhaps also instructions on how to run the code coverage reports.

@sbellem
Copy link
Author

sbellem commented Feb 5, 2024

I think that generating code coverage reports would be useful. Thanks, @sbellem !

Great! You're welcome!

@sbellem
Copy link
Author

sbellem commented Feb 5, 2024

It doesn't look like uploading code coverage to codecov.io is working in CI currently:

Sorry, should have mentioned this; an initial setup is needed, which I cannot do as organization membership/access is required. The Codecov GitHub app must be installed for the valida-xyz organization.

See https://docs.codecov.com/docs/quick-start for detailed instructions. Note the following:

If you are signing up via GitHub and not an admin of your Github organization, you may need to request access from an admin to authorize Codecov as a third-party Github application. For more information see GitHub Admin Authorization.

Also note that you don't need a repository upload token as it is not needed for open source projects.

@sbellem
Copy link
Author

sbellem commented Feb 5, 2024

It would be nice to update the README with instructions on how to access the generated code coverage reports, and perhaps also instructions on how to run the code coverage reports.

Ah yes, sure, will do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants