Fix constraint and test.

valida-xyz · Mar 18, 2024 · e1c336b · e1c336b
1 parent 93d6fe5
commit e1c336b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/alu_u32/src/lt/columns.rs b/alu_u32/src/lt/columns.rs
@@ -10,7 +10,7 @@ pub struct Lt32Cols<T> {
     pub input_2: Word<T>,
 
     /// Boolean flags indicating which byte pair differs
-    pub byte_flag: [T; 3],
+    pub byte_flag: [T; 4],
 
     /// Bit decomposition of 256 + input_1 - input_2
     pub bits: [T; 10],

diff --git a/alu_u32/src/lt/mod.rs b/alu_u32/src/lt/mod.rs
@@ -121,7 +121,7 @@ impl Lt32Chip {
             for i in 0..10 {
                 cols.bits[i] = F::from_canonical_u16(z >> i & 1);
             }
-            if n < 3 {
+            if n < 4 {
                 cols.byte_flag[n] = F::one();
             }
         }

diff --git a/alu_u32/src/lt/stark.rs b/alu_u32/src/lt/stark.rs
@@ -68,13 +68,10 @@ where
             .when_ne(local.bits[8], AB::Expr::one())
             .assert_one(local.output);
         // output should be 1 if is_lte & input_1 == input_2
+        let all_flag_sum = flag_sum + local.byte_flag[3];
         builder
             .when(local.is_lte)
-            .when_ne(flag_sum, AB::Expr::one())
-            .when_ne(
-                AB::Expr::from_canonical_u32(256) + local.input_1[3] - local.input_2[3],
-                AB::Expr::one(),
-            )
+            .when_ne(all_flag_sum, AB::Expr::one())
             .assert_one(local.output);
 
         // Check bit decomposition