Merge pull request #123 from valida-xyz/morgan/issue/122

issue/122: add missing constraints to zero tests
valida-xyz · Mar 18, 2024 · 04b0436 · 04b0436
2 parents 7e3f1dd + 2453881
commit 04b0436
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/alu_u32/src/com/stark.rs b/alu_u32/src/com/stark.rs
@@ -35,6 +35,8 @@ where
         );
         builder.assert_bool(local.not_equal);
         builder.assert_eq(local.not_equal, local.diff * local.diff_inv);
+        let equal = AB::Expr::one() - local.not_equal;
+        builder.assert_zero(equal * local.diff);
 
         builder.assert_bool(local.is_ne);
         builder.assert_bool(local.is_eq);

diff --git a/cpu/src/stark.rs b/cpu/src/stark.rs
@@ -267,6 +267,8 @@ impl CpuChip {
         );
         builder.assert_bool(local.not_equal);
         builder.assert_eq(local.not_equal, local.diff * local.diff_inv);
+        let equal = AB::Expr::one() - local.not_equal;
+        builder.assert_zero(equal * local.diff);
     }
 }