Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Custom Domains page #212

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Clarify Custom Domains page #212

merged 1 commit into from
Oct 15, 2024

Conversation

jakelazaroff
Copy link
Contributor

  • Use fully qualified domain names (example.com. with a . at the end) in custom domain examples
  • Add a note about CNAME flattening

stevekrouse
stevekrouse approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@stevekrouse stevekrouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jakelazaroff jakelazaroff merged commit 376c7e6 into main Oct 15, 2024
4 checks passed
@jakelazaroff jakelazaroff deleted the custom-domain-docs branch October 15, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekrouse stevekrouse stevekrouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakelazaroff @stevekrouse