Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: module starter #35

Merged
merged 20 commits into from
Apr 24, 2024
Merged

feat: module starter #35

merged 20 commits into from
Apr 24, 2024

Conversation

MarcinVaadin
Copy link
Member

@MarcinVaadin MarcinVaadin commented Apr 16, 2024

Description

Added Vaadin module type with starter download

Project Settings

image

Hello World Projects

image

Opened project

After creating project is opened on README.md (in preview mode, might be marked as using "experimental API").

image

Currently I don't know how to automatically load Maven / Gradle projects, will be improved in future.

@MarcinVaadin MarcinVaadin marked this pull request as draft April 16, 2024 13:45
@MarcinVaadin MarcinVaadin marked this pull request as ready for review April 17, 2024 11:28
@MarcinVaadin MarcinVaadin requested a review from emarc April 17, 2024 11:28
Copy link

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

)

val downloadLinks = mapOf(
"hilla-react" to "https://github.com/vaadin/skeleton-starter-hilla-react/archive/master.zip",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this master?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from Luoja, what should it be? v2?

"gradle" to "Gradle"
)

val downloadLinks = mapOf(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will we update these links when there are new versions? Will all existing plugins stop working / download an outdated project version? Should the links go through start.vaadin.com instead so we have a possibility to update them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might:

  1. Serve that name-url map from start
  2. Switch to use start presets only

Don't have strong opinion on that. It would be good to unify it at some point of time.

Copy link
Member

@Artur- Artur- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There does not seem to be any fundamentally wrong here that would prevent publication but we need to figure out the remaining details:

  1. better ux by having a one step wizard + automatic maven project import
  2. how to make the download links updateable so they won't refer to old versions even if you do not update the plugin

@MarcinVaadin
Copy link
Member Author

Merging as PR is too big already, work will be continued in separate, smaller PRs.

@MarcinVaadin MarcinVaadin merged commit 22956c9 into main Apr 24, 2024
3 checks passed
@MarcinVaadin MarcinVaadin deleted the feat/module-starter branch April 24, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants