-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: module starter #35
Conversation
1f910a5
to
78f3550
Compare
Artifact build on last commit: distributions.zip. |
) | ||
|
||
val downloadLinks = mapOf( | ||
"hilla-react" to "https://github.com/vaadin/skeleton-starter-hilla-react/archive/master.zip", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from Luoja, what should it be? v2?
"gradle" to "Gradle" | ||
) | ||
|
||
val downloadLinks = mapOf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will we update these links when there are new versions? Will all existing plugins stop working / download an outdated project version? Should the links go through start.vaadin.com instead so we have a possibility to update them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might:
- Serve that name-url map from start
- Switch to use start presets only
Don't have strong opinion on that. It would be good to unify it at some point of time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There does not seem to be any fundamentally wrong here that would prevent publication but we need to figure out the remaining details:
- better ux by having a one step wizard + automatic maven project import
- how to make the download links updateable so they won't refer to old versions even if you do not update the plugin
Merging as PR is too big already, work will be continued in separate, smaller PRs. |
Description
Added Vaadin module type with starter download
Project Settings
Hello World Projects
Opened project
After creating project is opened on
README.md
(in preview mode, might be marked as using "experimental API").Currently I don't know how to automatically load Maven / Gradle projects, will be improved in future.