Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Language injection for Flow #289

Merged
merged 2 commits into from
Jan 24, 2025
Merged

feat: Language injection for Flow #289

merged 2 commits into from
Jan 24, 2025

Conversation

jcgueriaud1
Copy link
Collaborator

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes #287 (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

It's a first version of the PR since it doesn't cover all the cases.
If the idea is good then we can check with methods can be added.

To create the XML, you can go Settings > Language injections and create your own rule then export it and include it in the XML.

image

Copy link
Member

@MarcinVaadin MarcinVaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

@MarcinVaadin MarcinVaadin enabled auto-merge (squash) January 24, 2025 08:35
@MarcinVaadin MarcinVaadin changed the title Language injection for Flow feat: Language injection for Flow Jan 24, 2025
@MarcinVaadin MarcinVaadin added the enhancement New feature or request label Jan 24, 2025
@MarcinVaadin MarcinVaadin merged commit 451b1ea into main Jan 24, 2025
8 checks passed
@MarcinVaadin MarcinVaadin deleted the language-injection branch January 24, 2025 08:41

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Language injections specific to Flow
2 participants