-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Analytics and Settings dialog #244
Conversation
Artifact build on last commit: distributions.zip. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly fine!
However I have detected an issue that happens with Macs silicon arch during plugin build. It would be under investigation because it looks like it is also related to the JDK so some combinations make the plugin unable to load a correct JNA version and the build fails.
As a temporary workaround for anyone developing, an exclusion can be added to the gradle file to prevent the license checker to load the problematic JNA library.
implementation("com.vaadin:license-checker:1.13.3") {
exclude(group = "net.java.dev.jna", module = "jna")
exclude(group = "net.java.dev.jna", module = "jna-platform")
}
Added usage statistics and Settings panel (so statistics can be disabled).