Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Analytics and Settings dialog #244

Merged
merged 7 commits into from
Jan 8, 2025
Merged

feat: Analytics and Settings dialog #244

merged 7 commits into from
Jan 8, 2025

Conversation

MarcinVaadin
Copy link
Member

Added usage statistics and Settings panel (so statistics can be disabled).

image

Copy link

github-actions bot commented Jan 8, 2025

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@mgarciavaadin mgarciavaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly fine!
However I have detected an issue that happens with Macs silicon arch during plugin build. It would be under investigation because it looks like it is also related to the JDK so some combinations make the plugin unable to load a correct JNA version and the build fails.
As a temporary workaround for anyone developing, an exclusion can be added to the gradle file to prevent the license checker to load the problematic JNA library.

 implementation("com.vaadin:license-checker:1.13.3") {
    exclude(group = "net.java.dev.jna", module = "jna")
    exclude(group = "net.java.dev.jna", module = "jna-platform")
  }

@mgarciavaadin mgarciavaadin merged commit cb849c8 into main Jan 8, 2025
10 checks passed
@mgarciavaadin mgarciavaadin deleted the chore/analytics branch January 8, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants