Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Hilla endpoints #196

Merged
merged 7 commits into from
Dec 17, 2024
Merged

feat: Hilla endpoints #196

merged 7 commits into from
Dec 17, 2024

Conversation

MarcinVaadin
Copy link
Member

@MarcinVaadin MarcinVaadin commented Dec 2, 2024 •
edited
Loading

VaadinEndpoints has been splitted into Flow and Hilla. Adds Hilla BrowserCallables to Endpoints list:

image

@MarcinVaadin MarcinVaadin changed the title support for Hilla feat: support for Hilla Dec 2, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@MarcinVaadin MarcinVaadin changed the title feat: support for Hilla feat: Hilla endpoints Dec 16, 2024
@github-actions GitHub Actions
Copy link

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

@MarcinVaadin MarcinVaadin marked this pull request as ready for review December 16, 2024 14:11
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@vaadin vaadin deleted a comment from github-actions bot Dec 16, 2024
mgarciavaadin
mgarciavaadin approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@mgarciavaadin mgarciavaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as promised in the PR so approving it!!
But just as a general comment, it feels weird that in the same list you have different things. Views for Flow and BrowserCallable for Hilla. Maybe we should rename the widget to something more general and try to add Hilla views together with Flow views (both with url mapping) and in a separated list the BrowserCallable elements.

@MarcinVaadin
Copy link
Member Author

But just as a general comment, it feels weird that in the same list you have different things. Views for Flow and BrowserCallable for Hilla.

You can filter by Vaadin Flow or Vaadin Hilla, by default there are both displayed.

@MarcinVaadin MarcinVaadin merged commit 7ec5cad into main Dec 17, 2024
10 checks passed
@MarcinVaadin MarcinVaadin deleted the feat/hilla branch December 17, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgarciavaadin mgarciavaadin mgarciavaadin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcinVaadin @mgarciavaadin