Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add config-file for ultimate dependencies #172

Merged
merged 5 commits into from
Nov 22, 2024
Merged

chore: add config-file for ultimate dependencies #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8fb90a
add config-file for ultimate dependencies
MarcinVaadin Nov 21, 2024
64b1757
nl
MarcinVaadin Nov 21, 2024
f5e579e
separate files, add verifies results as comment
MarcinVaadin Nov 21, 2024
8098e81
Disable flaky test
MarcinVaadin Nov 21, 2024
122e706
Enable test. Maybe it will pass.
MarcinVaadin Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
path: build/distributions
- uses: mshick/add-pr-comment@v2
with:
message-id: download-artifact-comment
refresh-message-position: true
message: |
Artifact build on last commit: [distributions.zip](${{ steps.artifact.outputs.artifact-url }}).
Expand All @@ -62,3 +63,14 @@ jobs:
cache: gradle
- name: Verify plugin
run: ./gradlew --no-configuration-cache verifyPlugin
- name: Find version
id: version
run: |
echo "IDE_VERSION=`ls build/reports/pluginVerifier/`" >> $GITHUB_OUTPUT
- name: Publish report
uses: mshick/add-pr-comment@v2
with:
message-id: verify-plugin-comment
refresh-message-position: true
message-path: |
build/reports/pluginVerifier/${{ steps.version.outputs.IDE_VERSION }}/report.md
6 changes: 5 additions & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import org.jetbrains.intellij.platform.gradle.TestFrameworkType
import org.jetbrains.intellij.platform.gradle.tasks.VerifyPluginTask

plugins {
id("java")
Expand Down Expand Up @@ -59,7 +60,10 @@ intellijPlatform {
"1.0-SNAPSHOT"
}
}
pluginVerification { ides { recommended() } }
pluginVerification {
ides { recommended() }
verificationReportsFormats = listOf(VerifyPluginTask.VerificationReportsFormats.MARKDOWN)
}
}

configure<com.diffplug.gradle.spotless.SpotlessExtension> {
Expand Down
6 changes: 3 additions & 3 deletions src/main/resources/META-INF/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@

<!-- Vaadin Endpoints IntelliJ Ultimate dependencies -->
<depends>com.intellij.properties</depends>
<depends optional="true">com.intellij.modules.microservices</depends>
<depends optional="true">com.intellij.microservices.jvm</depends>
<depends optional="true">com.intellij.modules.ultimate</depends>
<depends optional="true" config-file="vaadin-with-microservices.xml">com.intellij.modules.microservices</depends>
<depends optional="true" config-file="vaadin-with-microservices-jvm.xml">com.intellij.microservices.jvm</depends>
<depends optional="true" config-file="vaadin-with-ultimate.xml">com.intellij.modules.ultimate</depends>

<change-notes>
<![CDATA[
Expand Down
3 changes: 3 additions & 0 deletions src/main/resources/META-INF/vaadin-with-microservices-jvm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<idea-plugin>

</idea-plugin>
3 changes: 3 additions & 0 deletions src/main/resources/META-INF/vaadin-with-microservices.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<idea-plugin>

</idea-plugin>
3 changes: 3 additions & 0 deletions src/main/resources/META-INF/vaadin-with-ultimate.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<idea-plugin>

</idea-plugin>