Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Copy resources to build output #112

Closed
wants to merge 5 commits into from

Conversation

MarcinVaadin
Copy link
Member

Fixes #74

@MarcinVaadin MarcinVaadin requested a review from Artur- October 1, 2024 09:46
@MarcinVaadin MarcinVaadin changed the title feat: Copy binary resources on write feat: Copy base64 resources to build output Oct 1, 2024
@MarcinVaadin MarcinVaadin marked this pull request as draft October 1, 2024 10:03
@MarcinVaadin MarcinVaadin changed the title feat: Copy base64 resources to build output feat: Copy resources to build output Oct 2, 2024
@MarcinVaadin MarcinVaadin marked this pull request as ready for review October 2, 2024 10:56
Copy link

github-actions bot commented Oct 2, 2024

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

@@ -8,12 +8,12 @@ import com.intellij.psi.PsiFile
import com.intellij.psi.PsiManager
import java.io.File
import java.nio.file.Files
import java.util.Base64
import java.util.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s not use * here either

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm reverting, IntelliJ is changing it automatically

@Artur-
Copy link
Member

Artur- commented Oct 2, 2024

It looks like this implements manual copying - should it not be the same as ”compile” for Java files, so that the save action handles it also when saving in the IDE?

@MarcinVaadin
Copy link
Member Author

It looks like this implements manual copying - should it not be the same as ”compile” for Java files, so that the save action handles it also when saving in the IDE?

Let me have a second look if compile on save handles it also...

@Artur-
Copy link
Member

Artur- commented Oct 2, 2024

If we are handling Java files both manually in the Copilot command and through the save action, then we should do the same for resources. But we need to let IntelliJ do the actual copying/compiling

@MarcinVaadin
Copy link
Member Author

Will be continued in new, fresh PR

Artur- pushed a commit that referenced this pull request Nov 1, 2024
Copies resources to build directory

Fixes #112
@MarcinVaadin MarcinVaadin deleted the fix/copy-resources-on-save branch November 4, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntelliJ plugin should copy resources on save
2 participants