Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update browser details parse log output #20852

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

caalador
Copy link
Contributor

Do not log the exception stack trace
when failing version parse.
Message contains alrready required
information and the result is -1
and the app stays running.

touches #20838

Do not log the exception stack trace
when failing version parse.
Message contains alrready required
information and the result is -1
and the app stays running.

touches #20838
Copy link

Test Results

1 163 files  ± 0  1 163 suites  ±0   1h 29m 54s ⏱️ - 7m 8s
7 620 tests ± 0  7 564 ✅ ± 0  56 💤 ±0  0 ❌ ±0 
7 957 runs   - 29  7 893 ✅  - 28  64 💤  - 1  0 ❌ ±0 

Results for commit 7b20f3b. ± Comparison against base commit f0dbe87.

@mcollovati mcollovati merged commit 5997be0 into main Jan 16, 2025
24 of 26 checks passed
@mcollovati mcollovati deleted the issues/20838-log-message branch January 16, 2025 06:24
vaadin-bot pushed a commit that referenced this pull request Jan 16, 2025
Do not log the exception stack trace
when failing version parse.
Message contains alrready required
information and the result is -1
and the app stays running.

touches #20838
vaadin-bot added a commit that referenced this pull request Jan 16, 2025
Do not log the exception stack trace
when failing version parse.
Message contains alrready required
information and the result is -1
and the app stays running.

touches #20838

Co-authored-by: caalador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants