fix: make route config errors more prominent #20847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalador
previously approved these changes
Jan 15, 2025
caalador
reviewed
Jan 15, 2025
flow-server/src/main/java/com/vaadin/flow/router/internal/RouteSegment.java
Outdated
Show resolved
Hide resolved
caalador
reviewed
Jan 15, 2025
| @@ -791,9 +791,9 @@ private RuntimeException ambigousTarget(Class<? extends Component> target) { | |||
|
|
|||
| String messageFormat; | |||
| if (isParameter()) { | |||
| messageFormat = "Navigation targets must have unique routes, found navigation targets '%s' and '%s' with parameter have the same route."; | |||
| messageFormat = "Navigation target paths (considering @Route, @RouteAlias and @RoutePrefix values) must be unique, found navigation targets '%s' and '%s' with parameter having the same route."; | |||
There was a problem hiding this comment.
As 9 tests failed after updating the message perhaps it would make sense to have these as constants that are also used in the tests.
|
caalador
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When route configuration errors happen, make sure to output the actual error message as the first output at
ERRORlevel. When this is detected at startup, we can't prevent printing out the stack trace too since the container does that when initialization throws. Also checked all the messages for different route misconfiguration cases, and they seem to be fine.Fixes #20589