fix: set viewport-fit=cover to enable CSS env() variables in PWAs #20836
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
commented
Jan 13, 2025
flow-tests/test-ccdm/src/test/java/com/vaadin/flow/ccdmtest/IndexHtmlRequestHandlerIT.java
Outdated
Show resolved
Hide resolved
vursen
changed the title
|
|
I wonder if it's potentially a breaking change? |
I see a benefit of setting this option by default, because this gives a flexibility and customisability to developers to setup the viewport best alignment on modern side-to-side device screens, e.g. with Though this should be tested on various devices before released. And if we spot any significant changes in displaying, we may want to postpone this change to Vaadin 25. Do you @vursen or someone from Design System team mind to test this on various devices or shall Flow team do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
env()variables in PWAs requiresviewport-fit=coverto be set in the<meta name="viewport">. Without this setting, some parts of such components as app-layout get cut off on iOS devices. Addingviewport-fitfollows MDN's documentation aboutenv()variables and helps fix such issues .Fixes vaadin/web-components#8449
Type of change