Optimized apng detection algorithm #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madtisa
commented
Aug 9, 2024
•
madtisa
commented
- Reduced memory allocations by avoiding decoding buffer
- Increased algorithm performance by:
- replacing regex matching with index search
- going through buffer one time instead of two
- Reduce memory allocations by avoiding decoding buffer - Increase algorithm performance by: - replacing regex matching with index search - going through buffer one time instead of two
Added additional tests to check for false-positives (missing or preceding IDAT chunk).
* Fix: Catch false-positive where `acTL` is present, but no following `IDAT` * Perf: Refactored and simplified code
|
Thank you for the PR! Your algorithm is indeed more performant. I improved on it a bit more and will merge it in version |
madtisa
commented
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.