Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and remove systemd use in the setup scripts #9508

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Nov 22, 2024

What does this PR change?

Remove unused code in the setup scripts in order to ease refactoring them. This commit removes the need for systemd running as PID1 to run the setup script.

This also means that mgr-setup has to be called before running the real container and starting everything.

Note that some of the cleanup removing non-SUSE distributions handling, which shouldn't be a problem as Uyuni is now only shipped as a container built on a single openSUSE distro.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • CI needs to be adjusted

  • DONE

Links

Issue(s): #
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@cbosdo cbosdo requested a review from a team as a code owner November 22, 2024 15:59
@cbosdo cbosdo marked this pull request as draft November 22, 2024 15:59
@nadvornik
Copy link
Contributor

Maybe whole rhn-config-schema.pl can be dropped. It seems to do nothing in container setup. The output seems to be exactly the same as input.

@cbosdo cbosdo force-pushed the systemd-free-setup branch from f2a1d06 to 98b2fde Compare November 25, 2024 16:54
@cbosdo cbosdo marked this pull request as ready for review November 25, 2024 16:56
@cbosdo
Copy link
Contributor Author

cbosdo commented Nov 25, 2024

The merge of this PR has to be synchronized with uyuni-project/uyuni-tools#507

@cbosdo
Copy link
Contributor Author

cbosdo commented Nov 25, 2024

Maybe whole rhn-config-schema.pl can be dropped. It seems to do nothing in container setup. The output seems to be exactly the same as input.

I have the feeling that the whole schema-override thing is no longer around. @mcalmer can you confirm it?

@mcalmer
Copy link
Contributor

mcalmer commented Nov 25, 2024

Maybe whole rhn-config-schema.pl can be dropped. It seems to do nothing in container setup. The output seems to be exactly the same as input.

I have the feeling that the whole schema-override thing is no longer around. @mcalmer can you confirm it?

I think so. I never understood how it should work, so we never used it

@cbosdo
Copy link
Contributor Author

cbosdo commented Nov 27, 2024

Build tested in OBS and deployment working with the kubernetes operator.

@cbosdo cbosdo force-pushed the systemd-free-setup branch 2 times, most recently from 90cd846 to 17f0e2a Compare January 9, 2025 09:37
@cbosdo
Copy link
Contributor Author

cbosdo commented Jan 9, 2025

The changelog error can be ignored: dropped package.

The branch has been tested to works with both podman and kubernetes installations.

@cbosdo cbosdo force-pushed the systemd-free-setup branch from 17f0e2a to 43591b9 Compare January 10, 2025 11:13
Remove unused code in the setup scripts in order to ease refactoring
them. This commit removes the need for systemd running as PID1 to run
the setup script.

This also means that mgr-setup has to be called before running the real
container and starting everything.

Note that some of the cleanup removing non-SUSE distributions handling,
which shouldn't be a problem as Uyuni is now only shipped as a container
built on a single openSUSE distro.
@cbosdo cbosdo force-pushed the systemd-free-setup branch from 43591b9 to 4423a5b Compare January 10, 2025 12:49
@cbosdo cbosdo requested a review from aaannz January 21, 2025 14:09
@cbosdo cbosdo merged commit 52d3f3c into uyuni-project:master Jan 22, 2025
20 of 21 checks passed
@cbosdo cbosdo deleted the systemd-free-setup branch January 22, 2025 11:16
Copy link
Contributor

⚠️ Some changelog tests have failed. @cbosdo, please review and fix the changelog issues with an additional PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants