Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API session not up when getting monitoring system ID #9400

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

szachovy
Copy link
Contributor

@szachovy szachovy commented Oct 23, 2024

What does this PR change?

Approaches to solve session ID system call errors while calling API being an authorized user.

for i in {1..4}; do
  cucumber features/build_validation/init_clients/monitoring_server.feature:32 &
done
wait
....
Using the default profile...
# Copyright (c) 2022-2023 SUSE LLC
# Licensed under the terms of the MIT license.
@monitoring_server
Feature: Bootstrap the monitoring server

  @proxy
  Scenario: Check connection from monitoring server to proxy            # features/build_validation/init_clients/monitoring_server.feature:32
      This scenario ran at: 2024-10-23 13:11:30 +0200
Using the default profile...
# Copyright (c) 2022-2023 SUSE LLC
# Licensed under the terms of the MIT license.
@monitoring_server
Feature: Bootstrap the monitoring server

  @proxy
  Scenario: Check connection from monitoring server to proxy            # features/build_validation/init_clients/monitoring_server.feature:32
      This scenario ran at: 2024-10-23 13:11:30 +0200
Activating XML-RPC API
Activating XML-RPC API
Using the default profile...
# Copyright (c) 2022-2023 SUSE LLC
# Licensed under the terms of the MIT license.
@monitoring_server
Feature: Bootstrap the monitoring server

  @proxy
  Scenario: Check connection from monitoring server to proxy            # features/build_validation/init_clients/monitoring_server.feature:32
      This scenario ran at: 2024-10-23 13:11:31 +0200
Using the default profile...
# Copyright (c) 2022-2023 SUSE LLC
# Licensed under the terms of the MIT license.
@monitoring_server
Feature: Bootstrap the monitoring server

  @proxy
  Scenario: Check connection from monitoring server to proxy            # features/build_validation/init_clients/monitoring_server.feature:32
      This scenario ran at: 2024-10-23 13:11:31 +0200
    Given I am authorized for the "Admin" section                       # features/step_definitions/navigation_steps.rb:418
Initializing a remote node for 'monitoring_server'.
    Given I am authorized for the "Admin" section                       # features/step_definitions/navigation_steps.rb:418
Initializing a remote node for 'monitoring_server'.
Node: suma-bv-50-monitoring, OS Version: 15-SP4, Family: sles
Node: suma-bv-50-monitoring, OS Version: 15-SP4, Family: sles
    Given I am on the Systems overview page of this "monitoring_server" # features/step_definitions/navigation_steps.rb:432
    When I follow "Details" in the content area                         # features/step_definitions/navigation_steps.rb:314
    Given I am on the Systems overview page of this "monitoring_server" # features/step_definitions/navigation_steps.rb:432
    When I follow "Details" in the content area                         # features/step_definitions/navigation_steps.rb:314
    And I follow "Connection" in the content area                       # features/step_definitions/navigation_steps.rb:314
    And I follow "Connection" in the content area                       # features/step_definitions/navigation_steps.rb:314
Initializing a remote node for 'proxy'.
    Given I am authorized for the "Admin" section                       # features/step_definitions/navigation_steps.rb:418
Initializing a remote node for 'monitoring_server'.
    Given I am authorized for the "Admin" section                       # features/step_definitions/navigation_steps.rb:418
Initializing a remote node for 'monitoring_server'.
Initializing a remote node for 'proxy'.
Node: suma-bv-50-monitoring, OS Version: 15-SP4, Family: sles
Node: suma-bv-50-monitoring, OS Version: 15-SP4, Family: sles
    Given I am on the Systems overview page of this "monitoring_server" # features/step_definitions/navigation_steps.rb:432
Node: suma-bv-50-proxy, OS Version: 5.5, Family: sle-micro
    Given I am on the Systems overview page of this "monitoring_server" # features/step_definitions/navigation_steps.rb:432
Node: suma-bv-50-proxy, OS Version: 5.5, Family: sle-micro
    When I follow "Details" in the content area                         # features/step_definitions/navigation_steps.rb:314
    When I follow "Details" in the content area                         # features/step_definitions/navigation_steps.rb:314
    And I follow "Connection" in the content area                       # features/step_definitions/navigation_steps.rb:314
    And I follow "Connection" in the content area                       # features/step_definitions/navigation_steps.rb:314
    Then I should see "proxy" short hostname                            # features/step_definitions/navigation_steps.rb:618
      This scenario took: 16 seconds
# Visit monitoring endpoints on the minion
# Visit monitoring endpoints on the minion
# These are the 4 dashboards created by default when enabling the Grafana formula
# These are the 4 dashboards created by default when enabling the Grafana formula

1 scenario (1 passed)
5 steps (5 passed)
0m16.057s
    Then I should see "proxy" short hostname                            # features/step_definitions/navigation_steps.rb:618
      This scenario took: 15 seconds
# Visit monitoring endpoints on the minion
# Visit monitoring endpoints on the minion
# These are the 4 dashboards created by default when enabling the Grafana formula
# These are the 4 dashboards created by default when enabling the Grafana formula

1 scenario (1 passed)
5 steps (5 passed)
0m15.766s
Initializing a remote node for 'proxy'.
Initializing a remote node for 'proxy'.
[1]   Done                    cucumber features/build_validation/init_clients/monitoring_server.feature:32
[4]+  Done                    cucumber features/build_validation/init_clients/monitoring_server.feature:32
Node: suma-bv-50-proxy, OS Version: 5.5, Family: sle-micro
Node: suma-bv-50-proxy, OS Version: 5.5, Family: sle-micro
    Then I should see "proxy" short hostname                            # features/step_definitions/navigation_steps.rb:618
      This scenario took: 17 seconds
# Visit monitoring endpoints on the minion
# Visit monitoring endpoints on the minion
# These are the 4 dashboards created by default when enabling the Grafana formula
# These are the 4 dashboards created by default when enabling the Grafana formula

1 scenario (1 passed)
5 steps (5 passed)
0m17.216s
    Then I should see "proxy" short hostname                            # features/step_definitions/navigation_steps.rb:618
      This scenario took: 18 seconds
# Visit monitoring endpoints on the minion
# Visit monitoring endpoints on the minion
# These are the 4 dashboards created by default when enabling the Grafana formula
# These are the 4 dashboards created by default when enabling the Grafana formula

1 scenario (1 passed)
5 steps (5 passed)
0m17.635s
[2]-  Done                    cucumber features/build_validation/init_clients/monitoring_server.feature:32
[3]+  Done                    cucumber features/build_validation/init_clients/monitoring_server.feature:32

⚠️ Ports will be created if this concept is accepted.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/25578
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@szachovy szachovy requested a review from a team as a code owner October 23, 2024 11:01
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9400/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9400/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@szachovy szachovy force-pushed the 25578-api-session-not-up-when-getting-monitoring-system-id branch from 65fca7f to db1125c Compare October 24, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant