-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testsuite: update test containers to leap 15.5 #7648
Testsuite: update test containers to leap 15.5 #7648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some remarks
@@ -1,4 +1,4 @@ | |||
FROM opensuse/leap:15.4 | |||
FROM opensuse/leap:15.5 | |||
RUN zypper ref -f && \ | |||
zypper -n ar --no-gpgcheck http://download.opensuse.org/repositories/systemsmanagement:/sumaform:/tools/openSUSE_Leap_15.4/ tools && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zypper -n ar --no-gpgcheck http://download.opensuse.org/repositories/systemsmanagement:/sumaform:/tools/openSUSE_Leap_15.4/ tools && \ | |
zypper -n ar --no-gpgcheck http://download.opensuse.org/repositories/systemsmanagement:/sumaform:/tools/openSUSE_Leap_15.5/ tools && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jordimassaguerpla I also have a doubt on the list of installed packages.
postgresql-devel
-> this should still be version 14 because we didn't bump the postgresql version.
@@ -1,4 +1,4 @@ | |||
FROM registry.suse.com/bci/bci-init:15.4 | |||
FROM registry.suse.com/bci/bci-init:15.5 | |||
# from https://raw.githubusercontent.com/rjmateus/uyuni-container/main/uyuni/Dockerfile | |||
|
|||
RUN zypper ar -G http://download.opensuse.org/update/leap/15.4/backports/ backports_update_repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN zypper ar -G http://download.opensuse.org/update/leap/15.4/backports/ backports_update_repo | |
RUN zypper ar -G http://download.opensuse.org/update/leap/15.5/backports/ backports_update_repo |
and the same applies to the other repos mentioning 15.4 instead of 15.5
RUN zypper ar -G http://download.opensuse.org/distribution/leap/15.4/repo/oss/ os_pool_repo
RUN zypper ar -G http://download.opensuse.org/update/leap/15.4/oss/ os_update_repo
RUN zypper ar -G http://download.opensuse.org/update/leap/15.4/sle/ sle_update_repo
Sorry, I can't add a suggestion for changing also those
@@ -1,4 +1,4 @@ | |||
FROM registry.suse.com/bci/bci-init:15.4 | |||
FROM registry.suse.com/bci/bci-init:15.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why here we are using a SLE image instead openSUSE Leap. I know that the bci-init
is based on tumbleweed, not on Leap, but using SLE as base and adding Leap repos sounds weird to me
👋 Hello! Thanks for contributing to our project. Happy hacking! |
@deneb-alpha : Thanks for your feedback. I have addressed all your revisions. |
Signed-off-by: Jordi Massaguer Pla <[email protected]>
What does this PR change?
Testsuite: update test containers to leap 15.5
GUI diff
No difference.
Documentation
No documentation needed
DONE
Test coverage
Links
Fixes https://github.com/SUSE/spacewalk/issues/22694
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: