-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change openEuler url's for the Uyuni tools #7643
Conversation
@@ -4203,16 +4203,16 @@ repo_url = https://repo.openeuler.org/openEuler-22.03-LTS/EPOL/main/%(arch)s | |||
archs = x86_64, aarch64 | |||
name = Uyuni client tools for %(base_channel_name)s | |||
base_channels = openeuler2203-%(arch)s | |||
gpgkey_url = https://download.opensuse.org/repositories/systemsmanagement:/Uyuni:/Stable:/EL8-Uyuni-Client-Tools/EL_8/repodata/repomd.xml.key | |||
gpgkey_url = https://download.opensuse.org/repositories/systemsmanagement:/saltstack:/bundle:/next:/openEuler2203/openEuler_22.03/repodata/repomd.xml.key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we really need a separate bundle, then we'll need separate client tools at https://download.opensuse.org/repositories/systemsmanagement:/Uyuni:/Stable:/openEuler2203-Uyuni-Client-Tools/EL_8 @raulillo82 (at the same for Master, of course).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And @vzhestkov, I guess we'll need a fix at saltstack:bundle as well, not just next, so it can get linked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the last "EL-8" is extra, but yes, they don't exist yet. I wasn't very sure of what URL to write here, but creating this issue & PR would make things start :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
systemsmanagement:/Uyuni:/Stable:/EL8-Uyuni-Client-Tools/
is the project at OBS
EL_8
is the repository inside that project. You can check the UI.
For openEuler, if a separate bundle is really needed, you will need to create the OBS projects for both Master and Stable, Marina can help with that.
And then here you will get something like
https://download.opensuse.org/repositories/systemsmanagement:/Uyuni:/Stable:/openEuler2203-Uyuni-Client-Tools/openEuler_22.03 for the URLs (or the equivalent for Master)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliogonzalez given that openEuler 22.03
was already working using the EL9 client tools repos, I don't think we need to create a different set of project, right?
Or am I missing something?
The unique doubt I have now that I'm looking also at the prjconf is this:
https://build.opensuse.org/projects/systemsmanagement:saltstack:bundle:next:openEuler2203/prjconf
Prefer: open-sans-fonts
Macros:
%ext_man .gz
:Macros
that I don't see in https://build.opensuse.org/projects/systemsmanagement:Uyuni:Master:EL8-Uyuni-Client-Tools/prjconf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see differences in the prjconfs, but maybe they are not relevant
https://build.opensuse.org/projects/systemsmanagement:saltstack:bundle:next:openEuler2203/prjconf
https://build.opensuse.org/projects/systemsmanagement:saltstack:bundle:next:AlmaLinux8/prjconf
Still, I'd do a quick retest with EL8, if @vzhestkov confirms it makes sense using EL8. It could be the packages are building but there's son problem installing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in any case, the URLs used right now, https://download.opensuse.org/repositories/systemsmanagement:/saltstack:/bundle:/next:/openEuler2203/openEuler_22.03/ are not right. We'll need either EL8 client tools, either new openEuler 22.03 client tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in that case this PR would not be accepted and the code would be left as it is/was (so in the "files changed", left column would stay).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but this PR can't be accepted as it's either, if EL8 bundle can't be used.
It's OK to have it as you have it now for testing.
So before merging, and if EL8 client tools can't be used, new client tools for openEuler will need to be created and used here.
Leaving this unapproved until this is clarified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is exactly what I said: this PR will be discarded and things left as they are, with everything that was already merged in #6623
So during last learning Tuesday, @vzhestkov managed to patch EL8 salt bundle so that it included the conflicting missing libffi library, and with that everything was working. |
Closing, if anything arises when releasing next Uyuni version, we can always reopen this, but as far as I can see, this is invalid now. |
What does this PR change?
Fixes the url for the Uyuni tools as Almalinux 8 bundle stopped being used and openEuler got its own bundle.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: already covered
DONE
Links
Fixes #7642
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: