Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

States fail to apply to openEuler 22.03 client #7636

Closed
wants to merge 3 commits into from

Conversation

raulillo82
Copy link
Contributor

What does this PR change?

This PR fixes a wrong certificate for openEuler clients. Making the file be a symlink to redhat.sls was not working, and the original content of the name of the file did not work either. I think this was working in the first tests of the past though.
I'll be glad to hear about any other proposals.

GUI diff

Before: Registration failed with the step called "Apply states [certs, channels, packages, services.salt-minion]"
After: Registration won't fail any more.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Fixes #7635

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@raulillo82 raulillo82 self-assigned this Oct 4, 2023
@raulillo82 raulillo82 changed the title Fix 7635 States fail to apply to openEuler 22.03 client Oct 4, 2023
Copy link
Member

@juliogonzalez juliogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wait for Victor's approval, in case I am missing something else :-D

Copy link
Contributor

github-actions bot commented Dec 5, 2023

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 5, 2023
Copy link
Contributor

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Dec 16, 2023
@juliogonzalez juliogonzalez reopened this Dec 17, 2023
@juliogonzalez
Copy link
Member

Ping @vzhestkov

@github-actions github-actions bot removed the Stale label Dec 18, 2023
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

States fail to apply to openEuler 22.03 client
3 participants