Extend unique index for rhnpackagechangelogdata table #7531
Conversation
python/spacewalk/spacewalk-backend.changes.witek.extend-reposync-logging
Outdated
Show resolved
Hide resolved
| if 'importer' in locals(): | ||
| e_message += f'\nPackage: {repr(importer)}' | ||
| if src_importer: | ||
| if 'src_importer' in locals(): |
There was a problem hiding this comment.
One of the variables importer or src_importer is not assigned at that point and the UnboundLocalError is thrown.
Anyway, repr(importer) does not provide useful information, so I'll drop that part.
Inspite of client code trying to avoid duplicate records for changelog data such records are observed in the database. The change enforces unique combination of `name`, `time` and `text` fields by updating the definition of the unique index on the database level. Add logging package details during failed import. Clean up the logic for removing duplicate changelog entries.
witekest
force-pushed
the
extend-reposync-logging
branch
from
1db6f64
to
754a19c
Compare
witekest
changed the title
Use sha512 hashing to minimize collision risk
|
@cbosdo Could you take a look at the sonarcloud scanner failure? |
It looks like PRs coming form forks don't have access to the sonar token... |
|
@mackdk Could you please review the suggested new unique index for changelog entries? Thanks in advance. |
| @@ -28,8 +28,9 @@ CREATE TABLE rhnPackageChangeLogData | |||
|
|
|||
| ; | |||
|
|
|||
| CREATE INDEX rhn_pkg_cld_nt_idx | |||
| ON rhnPackageChangeLogData (name, time) | |||
| CREATE UNIQUE INDEX CONCURRENTLY rhn_pkg_cld_ntt_idx | |||
There was a problem hiding this comment.
I don't think CONCURRENTLY is accepted in a tables file because, as far as I know, these scripts are used to create the database from scratch.
There was a problem hiding this comment.
Good point, thanks.
| @@ -13,6 +13,7 @@ | |||
| -- in this software or its documentation. | |||
| -- | |||
|
|
|||
| CREATE EXTENSION IF NOT EXISTS pgcrypto; | |||
There was a problem hiding this comment.
I feel this should go in schema/spacewalk/postgres/start.sql. I see we have there already something for dblink there but I'm not sure to understand how that works. Maybe @mcalmer has more clues.
…7531) * Add unique index for rhnpackagechangelogdata table Inspite of client code trying to avoid duplicate records for changelog data such records are observed in the database. The change enforces unique combination of `name`, `time` and `text` fields by updating the definition of the unique index on the database level. Add logging package details during failed import. Clean up the logic for removing duplicate changelog entries.
What does this PR change?
In spite of client code trying to avoid duplicate records for changelog
data such records are observed in the database.
The change enforces unique combination of
name,timeandtextfields by updating the definition of the unique index on the database
level.
Additionally:
Links
Tracks suse/spacewalk#22470
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: