Token cleanup process improvements (bsc#1213376) #7415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
backport of:
Delete invalid tokens in token cleanup process (bsc#1211874)
Customers with a high number of session tokens which is taking a long time to be able to process the channel authentication.
These PR sets add more data clean-up when to de-associate the token from the minion.
If the token is expired or if the token is invalid and not associated with any minion we can delete it.
Besides that, I move the delete part from java processing to one single SQL statement. This makes the process cleaner and much faster.
It also improves the mechanism of propagates the new token generation by making a salt async call instead of schinchronized.
Also add a validation that the token needs to exist in the database, otherwise is considered invalid.
GUI diff
No difference.
Documentation
No documentation needed: internal process optimization
DONE
Test coverage
Unit tests updated and improved.
DONE
Links
Backport: https://github.com/SUSE/spacewalk/pull/21874
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: