Fix the images handling in mgradm support ptf
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Detect if the coco or hub image has been built in the PTF and apply it if needed |
cbosdo
force-pushed
the
ptf-fix
branch
3 times, most recently
from
785cb77
to
36535e6
Compare
The mgradm support ptf command has been designed with only the server image in mind, leave the coco and hub container untouched in such a case.
Reading the systemd services files requires hard coding their path, and would miss what the user could have added. To be on the safe side use systemd cat to get the whole definition and search for UYUNI_IMAGE value.
If the coco or hub image is built for a PTF, then we probably need to install it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
The mgradm support ptf command has been designed with only the server image in mind, leave the coco and hub container untouched in such a case.
Links
Issue(s): #
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!