Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing alt text and improved color contrast errors on contact … #129

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Added missing alt text and improved color contrast errors on contact … #129

merged 1 commit into from
Jul 16, 2024

Conversation

Rakielle
Copy link
Collaborator

@Rakielle Rakielle commented Jul 9, 2024

What does this PR change?

This PR resolves the low color contrast errors identified by WAVE on the contact page.

Changes Made

  • Added alt text to the Logo.
  • Applied background-color: rgba(255, 255, 255, 0.05); to elements with light foreground and background colors to improve readability.

Fixes #113

@Rakielle Rakielle requested a review from a team July 9, 2024 10:36
raulillo82
raulillo82 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@raulillo82 raulillo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I didn't see any change in wave errors (other than the 4 aria tabindex).
The alt text improvement is needed anyway.

@raulillo82 raulillo82 merged commit 13e994e into uyuni-project:master Jul 16, 2024
@Rakielle Rakielle deleted the improve-color-contrast-on-contact-page- branch July 16, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulillo82 raulillo82 raulillo82 approved these changes

@deneb-alpha deneb-alpha Awaiting requested review from deneb-alpha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contact page - 36 low contrast warnings
2 participants
@Rakielle @raulillo82