add flag prevent destroy to data disk #822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo Mateus <[email protected]>
moio
approved these changes
Jan 7, 2021
|
Hey @moio , This will not work, as explained in [1]. I just opened this PR to serve as documentation of what we cannot do and to be able to discuss it with you :) [1] #821 (comment) |
|
Oh, I am not reading my email in chronological order! I'd suggest to close this PR then. It's still around for reference, but at least it's clear it won't go anywhere 😉 Sorry for the noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ricardo Mateus [email protected]
What does this PR change?
Implementation of #821