Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xargs: Implement replace / -I (Closes: #310) #323

Merged
merged 9 commits into from
Apr 3, 2024

Conversation

sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Feb 25, 2024

Closes: #310

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 78.07018% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 58.36%. Comparing base (274d749) to head (45c1938).

Files Patch % Lines
tests/xargs_tests.rs 72.22% 0 Missing and 20 partials ⚠️
src/xargs/mod.rs 88.09% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   58.12%   58.36%   +0.23%     
==========================================
  Files          30       30              
  Lines        3630     3713      +83     
  Branches      821      841      +20     
==========================================
+ Hits         2110     2167      +57     
- Misses       1220     1223       +3     
- Partials      300      323      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre force-pushed the replace branch 2 times, most recently from ed2cbe6 to 3319bda Compare February 25, 2024 17:49
@sylvestre sylvestre requested a review from cakebaker February 25, 2024 18:02
@sylvestre sylvestre changed the title Implement replace xargs: Implement replace Mar 24, 2024
@sylvestre sylvestre changed the title xargs: Implement replace xargs: Implement replace / -I Mar 24, 2024
@sylvestre sylvestre force-pushed the replace branch 2 times, most recently from 5895040 to 0363266 Compare March 24, 2024 21:47
@sylvestre sylvestre changed the title xargs: Implement replace / -I xargs: Implement replace / -I (Closes: #310) Mar 25, 2024
Cargo.toml Outdated Show resolved Hide resolved
src/xargs/mod.rs Outdated Show resolved Hide resolved
src/xargs/mod.rs Outdated Show resolved Hide resolved
src/xargs/mod.rs Outdated Show resolved Hide resolved
src/xargs/mod.rs Outdated Show resolved Hide resolved
tests/xargs_tests.rs Outdated Show resolved Hide resolved
Copy link
Contributor Author

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we are good this time :)

tests/xargs_tests.rs Show resolved Hide resolved
@sylvestre sylvestre requested a review from cakebaker April 3, 2024 09:20
@cakebaker cakebaker merged commit 05d82ce into uutils:main Apr 3, 2024
13 checks passed
@cakebaker
Copy link
Contributor

Good work :)

@sylvestre sylvestre deleted the replace branch April 3, 2024 12:51
@sylvestre
Copy link
Contributor Author

many thanks for this terrific review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement -I / --replace
3 participants