Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve haskell spec metadata and publish Haddocks in CI #98

Merged
merged 6 commits into from
Jun 15, 2024
Merged

fix: Improve haskell spec metadata and publish Haddocks in CI #98

merged 6 commits into from
Jun 15, 2024

Conversation

domMayhew
Copy link
Contributor

@domMayhew domMayhew commented Jun 11, 2024 •
edited
Loading

In this PR

  1. Minor modifications to Haskell package metadata.
  2. Include Haddock (documentation) generation and publishing in the CI workflow.
  3. Include changes to documentation markdown after running buf generate proto.
    1. I'm not sure what the current process is regarding documentation, so I don't know if including these changes is appropriate. @wolf31o2 do you know?

@domMayhew domMayhew marked this pull request as ready for review June 11, 2024 20:06
wolf31o2
wolf31o2 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@wolf31o2 wolf31o2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... there's no CI to update the docs, yet... updating manually like this is currently the best way

@wolf31o2 wolf31o2 merged commit 386d155 into main Jun 15, 2024
5 of 6 checks passed
@wolf31o2 wolf31o2 deleted the fix/improve-haskell-spec-metadata branch June 15, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf31o2 wolf31o2 wolf31o2 approved these changes

@scarmuega scarmuega Awaiting requested review from scarmuega

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domMayhew @wolf31o2