-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added theme: nella-red #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the theme- could you make a couple of changes:
- Remove the lock file from the PR
- Add the theme to end of the list of options in the configuration component:
utterances/src/configuration-component.ts
Lines 129 to 136 in ad0d56c
<select id="theme" class="form-select" value="github-light" aria-label="Theme"> <option value="github-light">GitHub Light</option> <option value="github-dark">GitHub Dark</option> <option value="github-dark-orange">GitHub Dark Orange</option> <option value="icy-dark">Icy Dark</option> <option value="dark-blue">Dark Blue</option> <option value="photon-dark">Photon Dark</option> </select>
Hi can you review this PR? I need it approved before I can modify my website. Thank you! |
@jdanyow Hi can you merge this PR when you've got time plz? It's been a whole month and my website updating is postponed basically because of lack of this theme for utterances. Thanks a lot 🤖 |
HI @jdanyow can you review and approve this PR? It's been months... |
requested changes (yarn.lock) have not been addressed. |
Hi I think I've delete that file from commit. Can you explain why it's not addressed yet? Thanks |
Closing with another PR #422 |
New theme developed in order to make utterance comment area more consistent with my blog's overall theme. Changes in
yarn.lock
not necessarily need merging though.