battery.cppのパラメータ指定の誤りを訂正 #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kouchann
requested review from
200km,
ogoogo,
Hiro-0110,
seki-hiro,
suzuki-toshihir0,
t-hosonuma and
conjikidow
and removed request for
a team
200km
approved these changes
Jan 16, 2025
conjikidow
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Mention any issues that this pull request is related (e.g., #1). Consider using the
developmentfield if you want to close the issue automatically when this pull request is merged.Description
battery.cppにてCC充電時の電流値を引数にとる際、パラメータ名をconstant_charge_current_rate_Cとすべきところをconstant_charge_current_A_rate_Cとしてしまい引用できず、cc充電が模擬できなくなっていたので修正した。
Test results
Provide the test results and a link to the detailed results log.
Impact
Describe the scope of influence of the changes, e.g.,
The behavior of feature ** changes.Supplementary information
Provide any supplementary information.