Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS_IF_RX_BUFFER_SIZE の可変長化 #506

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

meltingrabbit
Copy link
Collaborator

@meltingrabbit meltingrabbit commented Mar 1, 2023

概要

DS_IF_RX_BUFFER_SIZE の可変長化

Issue

詳細

issueとdiffで追加した DS のコメントを参照

検証結果

既存のテストがすべて通った

影響範囲

  • rx_bufferサイズのバリデーションがより厳しくなっていることに注意
    • if (p->settings.rx_buffer_->capacity < p_super->config.settings.rx_buffer_size_in_if_rx_) return DS_ERR_CODE_ERR;
    • 小さい SW バッファを使う場合, Driver初期化時に DSC_set_rx_buffer_size_in_if_rx を呼び出すこと

備考

@meltingrabbit meltingrabbit added enhancement New feature or request priority::high priorityg high labels Mar 1, 2023
@meltingrabbit meltingrabbit self-assigned this Mar 1, 2023
@meltingrabbit meltingrabbit force-pushed the feature/ds_if_rx_buffer_size branch from 650a2b8 to d05e1fe Compare March 1, 2023 19:40
@meltingrabbit meltingrabbit force-pushed the feature/fix_name_of_uart_test_instance branch from 99e196f to 27fb5f9 Compare March 4, 2023 06:18
@meltingrabbit meltingrabbit force-pushed the feature/ds_if_rx_buffer_size branch from d05e1fe to cbb6530 Compare March 4, 2023 06:19
Copy link
Contributor

@chutaro chutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです。

これって、AOBCのセンサとかで rx_buffer を小さく設定した場合は、初期化時に rx_buffer_size_in_if_rx_ を rx_bufferと同じサイズにしたければいけないということですかね?

@meltingrabbit
Copy link
Collaborator Author

そう!

@meltingrabbit meltingrabbit force-pushed the feature/fix_name_of_uart_test_instance branch 3 times, most recently from 009241d to b63d987 Compare March 4, 2023 07:47
Base automatically changed from feature/fix_name_of_uart_test_instance to develop March 4, 2023 07:54
@meltingrabbit meltingrabbit force-pushed the feature/ds_if_rx_buffer_size branch from cbb6530 to 67aa0a9 Compare March 4, 2023 07:59
@meltingrabbit meltingrabbit merged commit d072800 into develop Mar 4, 2023
@meltingrabbit meltingrabbit deleted the feature/ds_if_rx_buffer_size branch March 4, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority::high priorityg high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants