Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Region Configuration to S3 Client Setup #120

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from

Conversation

elmiomar
Copy link
Contributor

This PR fixes an issue where the S3 client initialization fails due to a missing region.

Changes

  • Added the region property to the application.yml configuration file.
cloud:
  aws:
    region: us-east-1
  • Set a default value for the region variable used in the getAmazonS3() method.
@Value("${cloud.aws.region:us-east-1}")
String region;
  • Set service port to 0 (random) in unit tests to prevent conflicts with the actual service running on port 8083.

Testing

  • Unit tests pass.
  • Verified that the application starts successfully using oar-docker.

@elmiomar elmiomar requested a review from RayPlante January 24, 2025 03:04
@elmiomar elmiomar self-assigned this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant