Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/invalid file name handling #3274

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Pragadesh-45
Copy link
Contributor

fixes: #3266

Description

This PR implements the logic for validating filenames using a new utility function called isValidFilename to handle cases where filenames contain invalid characters \ / : * ? " < > | or end with a space ( ) or a period (.). This function has been added to the rename-item, thereby fixing issue #3266 , and to the new-request to improve error handling.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Before:

20241009-0655-37.1766450.mp4

After:

20241009-0658-03.9070602.mp4

@Pragadesh-45 Pragadesh-45 marked this pull request as ready for review October 15, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: can't use forward or backward slashes in request names
1 participant