Revised Documentation for Accuracy + Dev Container Java Update #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Devcontainer to Java 21
…README & added hyperlink
…entation Revised Documentation for Accuracy
…NAPSHOT Changed version to 1.7.0-SNAPSHOT
Release notes for jpo-sdw-depositor 1.7.0
dan-du-car
approved these changes
Jun 10, 2024
|
|
||
| Subscribes to a Kafka topic and deposits messages to the Situation Data Warehouse (SDW). | ||
| Subscribes to a Kafka topic and deposits messages to the [Situational Data Exchange (SDX)](https://sdx.trihydro.com/). |
There was a problem hiding this comment.
Not sure I understand what is the difference between the SDW and SDX. Do we need to rename this jpo-sdw-depositor to jpo-sdx-depositor?
There was a problem hiding this comment.
The SDX used to be called the SDW, but has since been renamed. Ideally the repository would be renamed to jpo-sdx-depositor to match, yeah.
|
Looks good. I left some minor comments. |
|
I've marked this PR as a draft until CDOT-CV#23 is merged. |
…-2024 Addressing USDOT PR Comments 6/11/2024
|
This is ready for re-review @dan-du-car |
dan-du-car
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised Documentation for Accuracy
Description
The documentation for the project has been reviewed and revised for accuracy. In some cases, improvements were made to formatting/organization to improve clarity.
Changes
Dev Container Java Update
Description
The dev container has been updated to use a Java 21 image, replacing the previous Java 17 image. This update enables the project to be compiled within the dev container.
Testing
All existing unit tests have been verified to pass with these changes.