Modified KafkaConsumerRestDepositor JSON processing #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style: lowercase method name
SDW Expiration Date Meta
test: additional test for estimatedRemovalDate inclusion chore: updated readme to reflect rename
SDW ExpirationDate refactor
9 tasks
dan-du-car
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SDX needs the ability to store an estimatedRemovalDate beyond what the ASN.1 encoding is able to describe.
Solution
Alterations to KafkaConsumerRestDepositor class for processing of JSONString within prepareJSONObject. Catching new optional data passed from the ASN1CommandManger to gather and forward on to the SDX.
Testing
The standard tests have been run and pass. Additional tests have been added to account for passing a JSON string as opposed to a simple string.
Dependent PR
This PR is paired with a second PR on the JPO-ODE branch.
usdot-jpo-ode/jpo-ode#532