Skip to content

Commit

Permalink
Remove plugin:vue/recommended overrides setup from .eslintrc.js (#2934)
Browse files Browse the repository at this point in the history
* Remove undesired last files from ignore list

These should have been removed already by prior PRs. I suspect they
remain because they were the victim of erroneous merge conflict fixing.

* Clean up eslintrc ignore setup \o/
  • Loading branch information
jeffsmohan authored Apr 22, 2024
1 parent 775e8d9 commit f9cd8cf
Showing 1 changed file with 0 additions and 61 deletions.
61 changes: 0 additions & 61 deletions packages/client/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,67 +26,6 @@ module.exports = {
'import/prefer-default-export': 'off',
},
overrides: [
// This override is part of the process of upgrading plugin:vue/essential -> plugin:vue/recommended.
// In order to avoid a huge stop-the-world PR, we're introducing the plugin upgrade and a file list here
// that ignores the added rules. That way, we can bring individual files into compliance in smaller, less
// disruptive PRs. We'll plan to burn down the list of files in this list until we're done and can remove
// this override entirely.
{
files: [
// File list to ignore generated by `yarn run lint --no-fix --format unix | sed -E 's/:.+//g' | uniq`
// then organized by hand into reasonable chunks of work

// ARPA Reporter: new views
'./src/arpa_reporter/views/NewTemplate.vue',
'./src/arpa_reporter/views/NewUpload.vue',

// Grant Finder: dashboard
'./src/views/Dashboard.vue',
'./src/views/RecentActivity.vue',
'./src/views/UpcomingClosingDates.vue',
'./src/components/ActivityTable.vue',
'./src/components/ClosingDatesTable.vue',
],
rules: {
// List of essential rules we previously had turned off
'vue/multi-word-component-names': 'off',
'vue/no-mutating-props': 'off',
// List of strongly recommended rules introduced (https://eslint.vuejs.org/rules/#priority-b-strongly-recommended-improving-readability)
'vue/attribute-hyphenation': 'off',
'vue/component-definition-name-casing': 'off',
'vue/first-attribute-linebreak': 'off',
'vue/html-closing-bracket-newline': 'off',
'vue/html-closing-bracket-spacing': 'off',
'vue/html-end-tags': 'off',
'vue/html-indent': 'off',
'vue/html-quotes': 'off',
'vue/html-self-closing': 'off',
'vue/max-attributes-per-line': 'off',
'vue/multiline-html-element-content-newline': 'off',
'vue/mustache-interpolation-spacing': 'off',
'vue/no-multi-spaces': 'off',
'vue/no-spaces-around-equal-signs-in-attribute': 'off',
'vue/no-template-shadow': 'off',
'vue/one-component-per-file': 'off',
'vue/prop-name-casing': 'off',
'vue/require-default-prop': 'off',
'vue/require-explicit-emits': 'off',
'vue/require-prop-types': 'off',
'vue/singleline-html-element-content-newline': 'off',
'vue/v-bind-style': 'off',
'vue/v-on-event-hyphenation': 'off',
'vue/v-on-style': 'off',
'vue/v-slot-style': 'off',
// List of recommended rules introduced (https://eslint.vuejs.org/rules/#priority-b-strongly-recommended-improving-readability)
'vue/attributes-order': 'off',
'vue/component-tags-order': 'off',
'vue/no-lone-template': 'off',
'vue/no-multiple-slot-args': 'off',
'vue/no-v-html': 'off',
'vue/order-in-components': 'off',
'vue/this-in-template': 'off',
},
},
{
files: [
'**/__tests__/*.{j,t}s?(x)',
Expand Down

0 comments on commit f9cd8cf

Please sign in to comment.