[MOBILE-4628] Add Webview inspection check in MessageCenter #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlepinski
reviewed
Jul 30, 2024
| /** | ||
| * Allows the WebViews to be inspected in Safari. | ||
| */ | ||
| isWebViewInspectionEnabled?: boolean; |
There was a problem hiding this comment.
this needs to be wired up in the mobile framework proxy
There was a problem hiding this comment.
Added in this PR : urbanairship/airship-mobile-framework-proxy#46
Ulrico972
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Why are these changes necessary?
To debug more easily the webviews
How did you verify these changes?
Putting isWebViewInspectionEnabled to true, running the sample app and inspecting the webview on Safari
Verification Screenshots:
Anything else a reviewer should know?
To make testing faster and easier I edited the ProxyConfig so it loads the new field from the config, so I think it would be great to add it in the next Proxy update