Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(next): added new import for nextjs with ssr disabled #48

Merged
merged 4 commits into from
Sep 27, 2024
Merged

feat(next): added new import for nextjs with ssr disabled #48

merged 4 commits into from
Sep 27, 2024

Conversation

egordidenko
Copy link
Contributor

Description

Checklist

nd0ut
nd0ut reviewed Sep 26, 2024
View reviewed changes
packages/react-uploader/package.json
@@ -24,7 +27,8 @@
"test": "vitest"
},
"peerDependencies": {
"@types/react": "17 || 18"
"@types/react": "17 || 18",
"next": "13 || 14"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to mark next dependency as optional peer: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta

@egordidenko egordidenko force-pushed the feat/dynamic-ssr-false-next branch 3 times, most recently from cba7718 to 020a234 Compare September 26, 2024 17:30
@egordidenko egordidenko merged commit 13e0e42 into main Sep 27, 2024
3 checks passed
@egordidenko egordidenko deleted the feat/dynamic-ssr-false-next branch September 27, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nd0ut nd0ut nd0ut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egordidenko @nd0ut